# HG changeset patch
# User drewp@bigasterisk.com
# Date 1685524582 25200
# Node ID 3b48a6e6a3c9aaaebd1ba89cc88333ecd26266e0
# Parent  63952949106b8b4d0c0199e1bd2ffa4816203104
just skip a fader with no value (it's probably coming soon)

diff -r 63952949106b -r 3b48a6e6a3c9 light9/effect/sequencer/eval_faders.py
--- a/light9/effect/sequencer/eval_faders.py	Wed May 31 01:19:57 2023 -0700
+++ b/light9/effect/sequencer/eval_faders.py	Wed May 31 02:16:22 2023 -0700
@@ -66,11 +66,16 @@
         faderEffectOutputs: List[DeviceSettings] = []
         now = UnixTime(time.time())
         for f in self.faders:
-            if f.value is None:
-                raise TypeError('f.value should be set by now')
-            effectSettings = EffectSettings(self.graph, [(f.effect, f.setEffectAttr, f.value)])
+            try:
+                if f.value is None:
+                    log.warning(f'{f.value=}; should be set during _compile. Skipping {f.uri}')
+                    continue
+                effectSettings = EffectSettings(self.graph, [(f.effect, f.setEffectAttr, f.value)])
 
-            ds = f.ee.compute(now, effectSettings)
-            faderEffectOutputs.append(ds)
+                ds = f.ee.compute(now, effectSettings)
+                faderEffectOutputs.append(ds)
+            except Exception:
+                log.warning(f'on fader {f}')
+                raise
 
         return DeviceSettings.merge(self.graph, faderEffectOutputs)