light9 Changeset - 9c2e1b5c16e9

Changeset - 9c2e1b5c16e9

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

drewp@bigasterisk.com - 3 years ago 2022-06-01 06:39:58
drewp@bigasterisk.com

speed: don't redo uri string replace all the time

1 file changed with 6 insertions and 11 deletions:

light9/web/live/Effect.ts

0 comments (0 inline, 0 general)

light9/web/live/Effect.ts

➞

Show inline comments

@@ @@ -26,24 +26,20 @@ function valuePred(graph: SyncedGraph, a @@
 // effect settings data; r/w sync with the graph
 export class Effect {
   private settings: Array<{ device: NamedNode; deviceAttr: NamedNode; setting: NamedNode; value: ControlValue }> = [];
+  private ctxForEffect: NamedNode
   constructor(
     public graph: SyncedGraph,
     public uri: NamedNode,
     // called if the graph changes our values and not when the caller uses edit()
     private onValuesChanged: (values: void) => void
   ) {
     this.ctxForEffect = this.graph.Uri(this.uri.value.replace("light9.bigasterisk.com/effect", "light9.bigasterisk.com/show/dance2019/effect"));
     graph.runHandler(this.rebuildSettingsFromGraph.bind(this), `effect sync ${uri.value}`);
+  }
   private ctxForEffect(): NamedNode {
     return this.graph.Uri(this.uri.value.replace("light9.bigasterisk.com/effect", "light9.bigasterisk.com/show/dance2019/effect"));
+  }
   addNewEffectToGraph() {
     const U = this.graph.U();
     const ctx = this.ctxForEffect();
     const quad = (s: Quad_Subject, p: Quad_Predicate, o: Quad_Object) => this.graph.Quad(s, p, o, ctx);
     const quad = (s: Quad_Subject, p: Quad_Predicate, o: Quad_Object) => this.graph.Quad(s, p, o, this.ctxForEffect);
     const addQuads = [
       quad(this.uri, U("rdf:type"), U(":Effect")),
@@ @@ -149,8 +145,7 @@ export class Effect { @@
   _addEffectSetting(device: NamedNode, deviceAttr: NamedNode, value: ControlValue): Patch {
     log("  _addEffectSetting", deviceAttr.value, value);
     const U = (x: string) => this.graph.Uri(x);
     const ctx = this.ctxForEffect();
     const quad = (s: Quad_Subject, p: Quad_Predicate, o: Quad_Object) => this.graph.Quad(s, p, o, ctx);
     const quad = (s: Quad_Subject, p: Quad_Predicate, o: Quad_Object) => this.graph.Quad(s, p, o, this.ctxForEffect);
     if (!this.uri) throw new Error("effect unset");
     const setting = this.graph.nextNumberedResource(this.uri.value + "_set");
@@ @@ -172,14 +167,14 @@ export class Effect { @@
       effectSetting, //
       valuePred(this.graph, deviceAttr),
       this._nodeForValue(value),
-      this.ctxForEffect()
       this.ctxForEffect
     );
+  }
   _removeEffectSetting(effectSetting: NamedNode): Patch {
     const U = (x: string) => this.graph.Uri(x);
     log("  _removeEffectSetting", effectSetting.value);
-    const toDel = [this.graph.Quad(this.uri, U(":setting"), effectSetting, this.ctxForEffect())];
     const toDel = [this.graph.Quad(this.uri, U(":setting"), effectSetting, this.ctxForEffect)];
     for (let q of this.graph.subjectStatements(effectSetting)) {
       toDel.push(q);
+    }

0 comments (0 inline, 0 general)