light9 Changeset - d0d5900a8031

Changeset - d0d5900a8031

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

drewp@bigasterisk.com - 9 years ago 2016-06-11 20:30:34
drewp@bigasterisk.com

collector run the blocking dmx output calls in another thread, so they don't add delay to our http server
Ignore-this: b5385085b654e1ac0b8018e6813f36e

2 files changed with 37 insertions and 12 deletions:

light9/collector/collector.py

light9/collector/output.py

0 comments (0 inline, 0 general)

light9/collector/collector.py

➞

Show inline comments

@@ @@ -109,9 +109,11 @@ class Collector(object): @@
             for outputAttr, value in attrs.iteritems():
                 self.setAttr(device, outputAttr, value, pendingOut)
-        print "%.1fms for client math" % (1000 * (time.time() - now))
+        dt1 = 1000 * (time.time() - now)
         self.flush(pendingOut)
         print "%.1fms including flush" % (1000 * (time.time() - now))
         dt2 = 1000 * (time.time() - now)
         if dt1 > 10:
             print "slow setAttrs: %.1fms -> flush -> %.1fms" % (dt1, dt2)
     def setAttr(self, device, outputAttr, value, pendingOut):
         output, index = self.outputMap[(device, outputAttr)]

light9/collector/output.py

➞

Show inline comments

@@ @@ -4,7 +4,7 @@ import sys @@
 import time
 import usb.core
 import logging
 from twisted.internet import task
+from twisted.internet import task, threads, reactor
 from greplin import scales
 log = logging.getLogger('output')
@@ @@ -54,6 +54,20 @@ class DmxOutput(Output): @@
     def flush(self):
         pass
     def _loop(self):
         start = time.time()
         sendingBuffer = self.currentBuffer
         def done(worked):
             if not worked:
                 self.countError()
             else:
                 self.lastSentBuffer = sendingBuffer
             reactor.callLater(max(0, start + 0.050 - time.time()),
                               self._loop)
         d = threads.deferToThread(self.sendDmx, sendingBuffer)
         d.addCallback(done)
 class EnttecDmx(DmxOutput):
     stats = scales.collection('/output/enttecDmx',
@@ @@ -68,7 +82,7 @@ class EnttecDmx(DmxOutput): @@
         self.dev = Dmx(devicePath)
         self.currentBuffer = ''
         self.lastLog = 0
-        task.LoopingCall(self._loop).start(0.050)
+        self._loop()
     @stats.update.time()
     def update(self, values):
@@ @@ -82,9 +96,13 @@ class EnttecDmx(DmxOutput): @@
         self.currentBuffer = '\x00' + ''.join(map(chr, values)) + "\x00"
     @stats.write.time()
-    def _loop(self):
+    def sendDmx(self, buf):
         self.dev.write(self.currentBuffer)
     def countError(self):
         pass
 class Udmx(DmxOutput):
     stats = scales.collection('/output/udmx',
                               scales.PmfStat('update'),
@@ @@ -105,7 +123,8 @@ class Udmx(DmxOutput): @@
         #   2. Retries if there are usb errors.
         # Copying the LoopingCall logic accomplishes those with a
         # little wasted time if there are no updates.
         task.LoopingCall(self._loop).start(0.050)
         #task.LoopingCall(self._loop).start(0.050)
         self._loop()
     @stats.update.time()
     def update(self, values):
@@ @@ -116,14 +135,18 @@ class Udmx(DmxOutput): @@
         self.currentBuffer = ''.join(map(chr, values))
     def _loop(self):
         #if self.lastSentBuffer == self.currentBuffer:
         #    return
     def sendDmx(self, buf):
         with Udmx.stats.write.time():
             # frequently errors with usb.core.USBError
             try:
                 self.dev.SendDMX(self.currentBuffer)
                 self.lastSentBuffer = self.currentBuffer
                 self.dev.SendDMX(buf)
                 return True
             except usb.core.USBError:
                 # not in main thread
                 return False
     def countError(self):
         # in main thread
                 Udmx.stats.usbErrors += 1

0 comments (0 inline, 0 general)